Fixed gcc -Wstringop-overflow and -Wdeprecated-declarations.#13
Open
AbdallaDalleh wants to merge 1 commit into
Open
Fixed gcc -Wstringop-overflow and -Wdeprecated-declarations.#13AbdallaDalleh wants to merge 1 commit into
AbdallaDalleh wants to merge 1 commit into
Conversation
1st warning:
../seq_mac.c: In function ‘seqMacEval’:
../seq_mac.c:81:5: warning: ‘strncpy’ specified bound depends on
the length of the source argument [-Wstringop-overflow=]
strncpy(outStr, value, valLth);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../seq_mac.c:75:14: note: length computed here
valLth = strlen(value);
seqMacEval already passes the destination size as the 4th argument
maxChar, this is clear in various calls:
- src/seq/seq_main.c:395
- src/seq/seq_if.c:668
2nd warning:
../../../include/seqMain.c: In function ‘main’:
../../../include/seqMain.c:28:9: warning: ‘epicsThreadExitMain’
is deprecated [-Wdeprecated-declarations]
epicsThreadExitMain();
function call has been replaced with a loop+sleep, as the deprecation
notice suggest. Similar call exist in test/validate/seqMain.c
Member
|
Careful with the 2nd one: |
Member
|
Works fine across Base versions, it seems. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1st warning:
seqMacEvalalready passes the destination size as the 4th argumentmaxChar, this is clear in various calls:src/seq/seq_main.c:395src/seq/seq_if.c:6682nd warning:
function call has been replaced with a loop+sleep, as the deprecation notice suggest. Similar case exist in
test/validate/seqMain.c